[ci] Use DotNetCoreCLI to sign macOS files #9102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been having issues with the signing steps that run doing the macOS build. Migration to a new post-build workflow is in progress, however this will hopefully fix things more quickly and be safer to backport.
|
Test run is here - https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9869333&view=logs&s=1afc3bfe-122c-538b-e9ad-2a86c2efcfef&j=96fd57f5-f69e-53c7-3d47-f67e6cf9b93e, looks like we've made it further than recent builds on main. Looking to rework this a bit in #9091 as well but this should be safer to backport as needed if it works. |
|
This doesn't crash, but it's timed out twice now so I guess it doesn't really work either... |
This reverts commit de50efa.
|
Looks like we got a successful run with CodeQL explicitly disabled. Not yet sure if signing services are running better this week or the CodeQL changes sped things up, but I've moved those changes into #9111. I think this should be good to go to at least fix our mono MSBuild crash in signing. |
jonathanpeppers
approved these changes
Jul 15, 2024
pjcollins
added a commit
that referenced
this pull request
Jul 15, 2024
We've been having issues with the signing steps that run doing the macOS build. Migration to a new post-build workflow is in progress, however this will hopefully fix things more quickly and be safer to backport.
grendello
added a commit
that referenced
this pull request
Jul 23, 2024
* main: (23 commits) Localized file check-in by OneLocBuild Task (#9129) [ci] Disable CodeQL on CI/PR pipelines (#9128) Refine 16k page alignment support (#9075) [build] fix `ConfigureLocalWorkload` target (#9124) Bump to NDK r27 (#9020) [ci] Use drop service for SDK insertion artifacts (#9116) Fix up all mapping paths (#9121) [ci] Fix maestro publishing for stable packages (#9118) Bump to dotnet/sdk@2f14fea98b 9.0.100-preview.7.24367.21 (#9108) Missing androidx.window.[extensions|sidecar] warnings (#9085) [ci] Use sign-artifacts template for macOS signing (#9091) [ci] Use DotNetCoreCLI to sign macOS files (#9102) [ci] Disable CodeQL on macOS, Linux, non-main jobs (#9111) [tests] re-enable `JavaAbstractMethodTest` (#9097) [Microsoft.Android.Sdk.ILLink] preserve types with `IJniNameProviderAttribute` (#9099) [Mono.Android] Data sharing and Close() overrides (#9103) [AndroidManifest] Add `Android.App.PropertyAttribute` (#9016) [Mono.Android] Add support for AndroidMessageHandler ClientCertificates (#8961) [Mono.Android] Bind and enumify API-35 (#9043) Bump to dotnet/java-interop@7a058c0e (#9066) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been having issues with the signing steps that run doing the macOS
build. Migration to a new post-build workflow is in progress, however
this will hopefully fix things more quickly and be safer to backport.