[Xamarin.Android.Build.Tasks] remove Microsoft.AspNetCore.App.Runtime.linux workaround #6851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….linux workaround Context: dotnet/sdk#19891 In 3f052b5, I added a workaround to exclude `Microsoft.AspNetCore.App.Runtime.linux` packages from Android builds. This was a problem where the `android` RID "inherited" from the `linux` RID, and so we ended up with unintended packages restored. This was fixed in dotnet/installer#12702, so we should remove this workaround.
dellis1972
approved these changes
Mar 24, 2022
|
The error is our old friend "java.util.zip.ZipException: invalid stored block lengths", it looks unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/sdk#19891
In 3f052b5, I added a workaround to exclude
Microsoft.AspNetCore.App.Runtime.linuxpackages from Android builds.This was a problem where the
androidRID "inherited" from thelinuxRID, and so we ended up with unintended packages restored.This was fixed in dotnet/installer#12702, so
we should remove this workaround.