[main] Update dependencies from dotnet/installer #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…210818.44 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-rc.1.21418.8 -> To Version 6.0.100-rc.2.21418.44 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref From Version 6.0.100-preview.6.21416.1 -> To Version 6.0.100-preview.6.21418.3 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro
bot
requested review from
jonathanpeppers,
jonpryor and
pjcollins
as code owners
Context: dotnet/runtime@57dd919 With the latest changes to `HttpClientHandler`, we hit: ILLink : warning IL2037: System.Net.Http.HttpClientHandler.GetClientCertificateOptions(): No members were resolved for 'get_ClientCertificateOptions'. ILLink : warning IL2037: System.Net.Http.HttpClientHandler.GetClientCertificates(): No members were resolved for 'get_ClientCertificates'. ILLink : warning IL2037: System.Net.Http.HttpClientHandler.SetClientCertificateOptions(ClientCertificateOption): No members were resolved for 'set_ClientCertificateOptions'. We need to add the missing members that are now expected: public ClientCertificateOption ClientCertificateOptions { get; set; } public X509CertificateCollection ClientCertificates { get; set; } We can also partially revert 1e5bfa3, because some of the issues were fixed.
grendello
approved these changes
Aug 19, 2021
Check API level for `SslProtocols`
See: https://github.com/dotnet/runtime/blob/0f5b75344d5858d76da403735ee34c71d9d69d54/src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.AnyMobile.cs#L776 There is not any `System.Reflection.BindingFlags` specified, so it would only work for `public` members.
jonathanpeppers
approved these changes
Aug 22, 2021
jonathanpeppers
deleted the
darc-main-0c1966a9-2608-444b-b9c1-cc22a86add7e
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/installer