[One .NET] Include symbol files in runtime packs #6193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the .pdb files associated with our framework assemblies to the .NET runtime packs. This will allow them to be fast deployed or included in an .aab/.apk for Debug builds. A couple of symbol related tests have been updated to also check for Mono.Android.pdb.
pjcollins
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
|
The test failures here look unrelated to me |
jonathanpeppers
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
I restarted a couple test phases that had weird errors.
This seems like it adds about 3MB to each runtime pack:
So I'll comment on #6058.
|
A lot of tests failed, I'm going to try a rerun which should pick up the latest changes in main. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Only a legacy |
jonathanpeppers
pushed a commit
that referenced
this pull request
Aug 20, 2021
Adds the .pdb files associated with our framework assemblies to the .NET runtime packs. This will allow them to be fast deployed or included in an .aab/.apk for Debug builds. A couple of symbol related tests have been updated to also check for Mono.Android.pdb. * Don't skip net6.0 msbuild smoke tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the .pdb files associated with our framework assemblies to the .NET
runtime packs. This will allow them to be fast deployed or included in
an .aab/.apk for Debug builds. A couple of symbol related tests have
been updated to also check for Mono.Android.pdb.
I also noticed that the
SmokeTestcategory was not running for thenet6.0MSBuildDeviceIntegration tests, as the emulator smoke test jobonly runs against the
net472test assembly. This currently doesn'tmatter as all
net6.0smoke tests are ignored through other categoryattributes, but this fix should be needed in the future.