-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0.1xx-preview6] Update dependencies from dotnet/installer #6034
Merged
jonathanpeppers
merged 8 commits into
release/6.0.1xx-preview6
from
darc-release/6.0.1xx-preview6-565bfe6c-0e2c-4495-b959-98023e82e96c
Jun 23, 2021
Merged
[release/6.0.1xx-preview6] Update dependencies from dotnet/installer #6034
jonathanpeppers
merged 8 commits into
release/6.0.1xx-preview6
from
darc-release/6.0.1xx-preview6-565bfe6c-0e2c-4495-b959-98023e82e96c
Jun 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…210620.7 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21313.2 -> To Version 6.0.100-preview.6.21320.7 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref From Version 6.0.100-preview.6.21304.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro
bot
requested review from
jonathanpeppers,
jonpryor and
pjcollins
as code owners
June 21, 2021 14:36
Context: dotnet/runtime#53811 dotnet/runtime#53811 is now solved, so we can remove the workaround.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…210621.13 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21313.2 -> To Version 6.0.100-preview.6.21321.13 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref From Version 6.0.100-preview.6.21304.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal
This was referenced Jun 22, 2021
…view6-565bfe6c-0e2c-4495-b959-98023e82e96c
Context: dotnet/msbuild#6609 It seems that properties are missing from MSBuild logs, ignoring part of this test for now.
…210623.1 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21313.2 -> To Version 6.0.100-preview.6.21323.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref From Version 6.0.100-preview.6.21304.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal
Context: dotnet/templating#3325 Context: https://github.com/dotnet/templating/wiki/Reference-for-template.json#content-manipulation In the current bump, `dotnet new android` + `dotnet build` fails with: Resources\mipmap-xxxhdpi\ic_launcher_round.png error APT2000: failed reading from input: PNG chunk type 49444154 is too large: chunk length is 10836 but chunk starts at byte 45/8187. The .NET templating system has a 'copyOnly' mode for files that do not need any text replaced. This is a performance feature, but it also happens to workaround this issue. We should be doing this on `.png` files *anyway*, as we don't need potential "text" to be replaced. I will probably need to make similar changes in xamarin/xamarin-macios and dotnet/maui.
jonathanpeppers
approved these changes
Jun 23, 2021
jonathanpeppers
deleted the
darc-release/6.0.1xx-preview6-565bfe6c-0e2c-4495-b959-98023e82e96c
branch
June 23, 2021 20:21
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/installer