[android-toolchain] Fix the location of the android tools #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per prior discussion, why use The advantages to
|
The current directory structure for the android sdk does NOT match the one that google creates. The tools are not in a tools subdirectory when they should be. As a result things like the sdkmanager do not run. It also causes problems for Xamarin Studio since its looking for things in different places. This commit fixes up the tools .zip that we download to make sure the tools are extacted to the correct directory. This is because the new zip file contains the tools directory within it rather than just being a flat zip file. Also it is the recommended tools download from google [1] [1] http://developer.android.com/sdk/index.html#mac-tools
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jul 21, 2022
Changes: mono/opentk@50128f7...daa9b2d * mono/opentk@daa9b2d5: [nuget] use $(PackageLicenseExpression), not $(PackageLicenseUrl) (dotnet#35) * mono/opentk@351eb656: [ci] Use new EO compliant build pools (dotnet#33) * mono/opentk@95ab20b1: Try to fix DllNotFoundException under .net 6 (dotnet#32) * mono/opentk@3de39a40: Merge pull request dotnet#30 from dellis1972/proguard * mono/opentk@79ea8095: rework * mono/opentk@3311a8ac: Add Proguard config support
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jul 22, 2022
Changes: mono/opentk@50128f7...daa9b2d * mono/opentk@daa9b2d5: [nuget] use $(PackageLicenseExpression), not $(PackageLicenseUrl) (dotnet#35) * mono/opentk@351eb656: [ci] Use new EO compliant build pools (dotnet#33) * mono/opentk@95ab20b1: Try to fix DllNotFoundException under .net 6 (dotnet#32) * mono/opentk@3de39a40: Merge pull request dotnet#30 from dellis1972/proguard * mono/opentk@79ea8095: rework * mono/opentk@3311a8ac: Add Proguard config support
jonpryor
added a commit
that referenced
this pull request
Jul 26, 2022
Changes: mono/opentk@50128f7...daa9b2d * mono/opentk@daa9b2d5: [nuget] use $(PackageLicenseExpression), not $(PackageLicenseUrl) (#35) * mono/opentk@351eb656: [ci] Use new EO compliant build pools (#33) * mono/opentk@95ab20b1: Try to fix DllNotFoundException under .net 6 (#32) * mono/opentk@3de39a40: Merge pull request #30 from dellis1972/proguard * mono/opentk@79ea8095: rework * mono/opentk@3311a8ac: Add Proguard config support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current directory structure for the android sdk does NOT
match the one that google creates. The tools are not in a
tools subdirectory when they should be. As a result things like
the sdkmanager do not run. It also causes problems for Xamarin Studio
since its looking for things in different places.
This commit fixes up the tools .zip that we download to make sure
the tools are extacted to the correct directory. This is because
the new zip file contains the tools directory within it rather than
just being a flat zip file. Also it is the recommended tools download
from google [1]
[1] http://developer.android.com/sdk/index.html#mac-tools