Skip to content

Commit

Permalink
[Mono.Android] Enable all Map.Of() methods (#5106)
Browse files Browse the repository at this point in the history
Context: dotnet/java-interop@56955d9

When binding API-30, we disabled some `java.util.Map.of()`  overloads
whicg took more than 14 parameters (a20be39), as we could not
support them with C# `Action<…>`/`Func<…>` constructs.

With dotnet/java-interop@56955d9a, the restriction to only bind
methods with <= 14 parameters has been removed, allowing *all*`
`Map.of()` methods to be bound.

Enable all the `Map.of()` methods.
  • Loading branch information
jpobst authored and jonpryor committed Sep 17, 2020
1 parent 4e84575 commit 19053c1
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/Mono.Android/metadata
Original file line number Diff line number Diff line change
Expand Up @@ -1548,11 +1548,6 @@
<remove-node api-since="30" path="/api/package[@name='android.telephony']/class[@name='CellInfo']/method[@name='getCellIdentity' and count(parameter)=0]" />
<remove-node api-since="30" path="/api/package[@name='android.telephony']/class[@name='CellInfo']/method[@name='getCellSignalStrength' and count(parameter)=0]" />

<!-- We don't support methods that require Actions/Functions with more than 16 arguments -->
<remove-node api-since="30" path="/api/package[@name='java.util']/interface[@jni-signature='Ljava/util/Map;']/method[@name='of' and count(parameter)=16]" />
<remove-node api-since="30" path="/api/package[@name='java.util']/interface[@jni-signature='Ljava/util/Map;']/method[@name='of' and count(parameter)=18]" />
<remove-node api-since="30" path="/api/package[@name='java.util']/interface[@jni-signature='Ljava/util/Map;']/method[@name='of' and count(parameter)=20]" />

<!-- Work around a generator bug where having multiple Listener methods with the same name cause multiple conflicting EventArgs classes to be created. -->
<!-- These are "default" method versions, so it's ok to remove them from an interface. -->
<remove-node api-since="30" path="/api/package[@name='android.animation']/interface[@name='Animator.AnimatorListener']/method[@name='onAnimationStart' and count(parameter)=2]" />
Expand Down

0 comments on commit 19053c1

Please sign in to comment.