Return empty DataTable from GetSchemaTable. #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused code from DataReaderTest fixes dotnet#417
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderTest.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
added
the
🔨 Breaking Change
cheenamalhotra
approved these changes
Feb 11, 2020
David-Engel
approved these changes
Feb 11, 2020
roji
reviewed
Aug 11, 2020
| @@ -65,7 +64,25 @@ public static void MultiQuerySchema() | |||
| } | |||
| } | |||
|
|
|||
| [CheckConnStrSetupFact] | |||
| public static void GetSchemaTable_returns_null_when_no_resultset() | |||
There was a problem hiding this comment.
Another possible note is the returned table should have no rows, but should still have the columns it has when there are rows.
cheenamalhotra
added a commit
to cheenamalhotra/SqlClient
that referenced
this pull request
Aug 19, 2020
cheenamalhotra
added a commit
to cheenamalhotra/SqlClient
that referenced
this pull request
Aug 19, 2020
This was referenced Aug 19, 2020
cheenamalhotra
added a commit
that referenced
this pull request
Aug 19, 2020
cheenamalhotra
added a commit
that referenced
this pull request
Aug 20, 2020
TrayanZapryanov
pushed a commit
to TrayanZapryanov/SqlClient
that referenced
this pull request
Aug 31, 2020
TrayanZapryanov
added a commit
to TrayanZapryanov/SqlClient
that referenced
this pull request
Aug 31, 2020
…)" (dotnet#696)" This reverts commit a0dcabe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused code from DataReaderTest
fixes #417