Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align newlines between netfx and netcore #2954

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 2, 2024

All this PR does is align empty lines / newlines between netfx and netcore for easier merging later.
Part of #2953

@MichelZ MichelZ changed the title Align newlines between netfx and netcore #2953 Align newlines between netfx and netcore Nov 2, 2024
Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I don't think this is necessary for merging the class, but if it helps with your plan for merging, I'll take it.

@benrr101 benrr101 added the Common Project 🚮 Things that relate to the common project project label Nov 4, 2024
@benrr101
Copy link
Contributor

benrr101 commented Nov 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.49%. Comparing base (9d5ca32) to head (ce66c57).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2954      +/-   ##
==========================================
+ Coverage   72.31%   75.49%   +3.18%     
==========================================
  Files         288      246      -42     
  Lines       59660    40194   -19466     
==========================================
- Hits        43145    30346   -12799     
+ Misses      16515     9848    -6667     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.36% <ø> (-0.07%) ⬇️
netfx ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101 benrr101 merged commit 69ac9c5 into dotnet:main Nov 5, 2024
76 checks passed
@benrr101 benrr101 added this to the 6.0-preview3 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants