Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Add multipacket async read target buffer caching #285

Merged
merged 2 commits into from
Nov 7, 2019
Merged

perf: Add multipacket async read target buffer caching #285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcaaaa3
add plp target buffer caching
Wraith2 Oct 24, 2019
33735e4
resolve merge conflict
Wraith2 Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 32 additions & 6 deletions src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1910,7 +1910,7 @@ internal int ReadPlpBytesChunk(byte[] buff, int offset, int len)
// Every time you call this method increment the offset and decrease len by the value of totalBytesRead
internal bool TryReadPlpBytes(ref byte[] buff, int offset, int len, out int totalBytesRead)
{
int bytesRead = 0;
int bytesRead;
int bytesLeft;
byte[] newbuf;
ulong ignored;
Expand All @@ -1928,16 +1928,27 @@ internal bool TryReadPlpBytes(ref byte[] buff, int offset, int len, out int tota
return true; // No data
}

Debug.Assert((_longlen != TdsEnums.SQL_PLP_NULL),
"Out of sync plp read request");

Debug.Assert(_longlen != TdsEnums.SQL_PLP_NULL, "Out of sync plp read request");
Debug.Assert((buff == null && offset == 0) || (buff.Length >= offset + len), "Invalid length sent to ReadPlpBytes()!");

bytesLeft = len;

// If total length is known up front, allocate the whole buffer in one shot instead of realloc'ing and copying over each time
if (buff == null && _longlen != TdsEnums.SQL_PLP_UNKNOWNLEN)
{
buff = new byte[(int)Math.Min((int)_longlen, len)];
if (_snapshot != null)
{
// if there is a snapshot and it contains a stored plp buffer take it
// and try to use it if it is the right length
buff = _snapshot._plpBuffer;
_snapshot._plpBuffer = null;
}

if ((ulong)(buff?.Length ?? 0) != _longlen)
{
// if the buffer is null or the wrong length create one to use
buff = new byte[(int)Math.Min((int)_longlen, len)];
}
}

if (_longlenleft == 0)
Expand Down Expand Up @@ -1982,13 +1993,26 @@ internal bool TryReadPlpBytes(ref byte[] buff, int offset, int len, out int tota
_longlenleft -= (ulong)bytesRead;
if (!result)
{
if (_snapshot != null)
{
// a partial read has happened so store the target buffer in the snapshot
// so it can be re-used when another packet arrives and we read again
_snapshot._plpBuffer = buff;
}
return false;
}

if (_longlenleft == 0)
{ // Read the next chunk or cleanup state if hit the end
{
// Read the next chunk or cleanup state if hit the end
if (!TryReadPlpLength(false, out ignored))
{
if (_snapshot != null)
{
// a partial read has happened so store the target buffer in the snapshot
// so it can be re-used when another packet arrives and we read again
_snapshot._plpBuffer = buff;
}
return false;
}
}
Expand Down Expand Up @@ -3941,6 +3965,8 @@ partial void SetStackInternal(string value)
private NullBitmap _snapshotNullBitmapInfo;
private _SqlMetaDataSet _snapshotCleanupMetaData;
private _SqlMetaDataSetCollection _snapshotCleanupAltMetaDataSetArray;

internal byte[] _plpBuffer;
private PLPData _plpData;
private TdsParserStateObject _stateObj;

Expand Down