-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged DbConnectionClosed, DbConnectionFactory, SqlAuthenticationProviderManager #2410
Merged DbConnectionClosed, DbConnectionFactory, SqlAuthenticationProviderManager #2410
Conversation
@edwardneal Can you address the conflicts, please? |
Thanks @DavoudEshtehari, I've addressed the conflicts. CI is effectively done - there are a few test failures, which seem to be unrelated. |
One more conflict after merging your PR. ;) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2410 +/- ##
==========================================
- Coverage 72.03% 72.02% -0.01%
==========================================
Files 305 299 -6
Lines 61804 61394 -410
==========================================
- Hits 44522 44221 -301
+ Misses 17282 17173 -109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks - re-merged. The test failures remain unrelated |
Contributes to #1261.
This merges the three classes above. DbConnectionFactory has a few references to the metric reporting processes (which are different between .NET Core and Framework) and I've hidden these behind conditional compilation.