Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #1261.
This merges SqlFileStream between .NET Core and Framework. In the process, I've also implicitly dropped a code path to set the process-level or thread-level exception mode. This code path would set the thread-level exception mode on Windows 7 or higher, and the process-level exception mode on Windows XP or below; I've discarded the latter path.
SqlFileStream depends on a handful of PInvokes and a PathInternal class. I've merged these too, trimming unused methods where applicable. The removal of the former instances of these accounts for 70-80% of the removals.
I've also added ReadAsync and WriteAsync methods to SqlFileStream in .NET Core. The underlying FileStream supports these, so it doesn't do any harm to pass them through.