Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SqlConnectionString.cs #1359

Merged
merged 6 commits into from
Oct 20, 2021
Merged

Refactor SqlConnectionString.cs #1359

merged 6 commits into from
Oct 20, 2021

Commits on Oct 19, 2021

  1. Remove Asynchronous default variable and unreferenced Asynchronous pr… 

    …operty in SqlConnection
    @lcheunglci
    lcheunglci committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    73940ae View commit details
    Browse the repository at this point in the history

  2. Replaced IntegratedWithPassword with IntegratedWithUserIDAndPassword … 

    …to unify behaviour between netcore and netfx
    @lcheunglci
    lcheunglci committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    a5d3e12 View commit details
    Browse the repository at this point in the history

  3. Reverse the order of the static and internal keyword for the meth… 

    …od IntegratedWithUserIDAndPassword
    @lcheunglci
    lcheunglci committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    6d30435 View commit details
    Browse the repository at this point in the history

  4. Revert changes to the IntegratedWithPassword on netcore

    @lcheunglci
    lcheunglci committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    79af725 View commit details
    Browse the repository at this point in the history

  5. Replace IntegratedWithUserIDAndPassword with IntegratedWithPassword a… 

    …nd update the string resources
    @lcheunglci
    lcheunglci committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    4d3dc7f View commit details
    Browse the repository at this point in the history

  6. Add unit tests to verify the exception when ActiveDirectoryIntegrated… 

    … is set, and pwd and uid are specficied
    @lcheunglci
    lcheunglci committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    b6df8b9 View commit details
    Browse the repository at this point in the history