Move into Shared for SqlReferenceCollection.cs #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and updated references in the csprojs and fix compiler error removing internal method with no references
DavoudEshtehari
added
the
➕ Code Health
johnnypham
approved these changes
Oct 1, 2021
Kaur-Parminder
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #1261 . I diff'ed the netcore vs with netfx version of SqlReferenceCollection.cs and found that the logic is nearly the same with the exception of the
FindLiveCommandmethod which referenced inSqlInternalConnection.cson netfx in an internal method and is never used with no references. I tried to mergeSqlInternalConnection.csbut realized that there was a dependency on SqlDataReader which is not merged yet and the SqlInternalConnectionTds and SqlInternalConnectionSmi would be affected too, so I kept changes small by removing theFindLiveCommandin SqlInternalConnection in netfx and will open another PR for that. The netcore version of SqlReferenceCollection.cs then added into share src and updated references in the csprojs.