Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move into shared for TimeoutTimer.cs #1273

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

lcheunglci
Copy link
Contributor

In regards to issue #1261, I moved the TimeoutTimer.cs from the dotnet to src and updated the reference from the netfx version

@dnfadmin
Copy link

dnfadmin commented Sep 22, 2021

CLA assistant check
All CLA requirements met.

@Wraith2
Copy link
Contributor

Wraith2 commented Sep 22, 2021

You probably don't want to include it in the netfx project file until it's used by something in the netfx build.

@lcheunglci
Copy link
Contributor Author

You probably don't want to include it in the netfx project file until it's used by something in the netfx build.

Thanks for the recommendation. I did verify it's being referenced in the netfx project in SqlClient\src\Microsoft.Data.SqlClient\netfx\src\Microsoft\Data\SqlClient\SqlInternalConnectionTds.cs

@DavoudEshtehari DavoudEshtehari added the ➕ Code Health Changes related to source code improvements label Sep 22, 2021
@DavoudEshtehari DavoudEshtehari added this to the 4.0.0-preview3 milestone Sep 22, 2021
@lcheunglci lcheunglci changed the title MergeSNI for TimeoutTimer.cs Move into shared for TimeoutTimer.cs Sep 22, 2021
Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor naming rule violation here: internal static readonly long s_infiniteTimeout = 0;
Plus an extra blank line at the end of TimeoutTimer.cs.

@cheenamalhotra cheenamalhotra merged commit a77f2ae into dotnet:main Oct 6, 2021
@lcheunglci lcheunglci deleted the MergeSNI-TimeoutTimer branch October 14, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Changes related to source code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants