Remove designer attribute from SqlCommand and SqlDataAdapter #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnypham
changed the title
|
For some reason they are also in netcore ref class, might as well clean that up. |
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs
Show resolved
Hide resolved
cheenamalhotra
approved these changes
Jun 23, 2021
|
Is there a VS issue opened to track adding this library to the types VS knows about? |
|
There isn't any, I was thinking the same. I might get some conversations started internally, but it doesn't seem they would be replacing existing classes anyways. Most likely new set of classes would be available in future VS - then we'll include those here. |
DavoudEshtehari
approved these changes
Jun 28, 2021
DavoudEshtehari
pushed a commit
to Wraith2/SqlClient
that referenced
this pull request
Sep 1, 2021
…1132) * remove designer attribute * remove designer and toolboxitem attribute from sqldataadapter * remove from refs * remove from netcore refs * add TODOs in netfx refs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1110