Reset cached async state on disposing a command #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraith2
reviewed
Jun 18, 2021
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs
Show resolved
Hide resolved
|
Looks reasonable. Is it worth checking that the cached async state is correctly reset when the connection is returned to the pool? |
DavoudEshtehari
changed the title
DavoudEshtehari
changed the title
# Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIStreams.cs
johnnypham
approved these changes
Jul 28, 2021
JRahnama
approved these changes
Jul 28, 2021
DavoudEshtehari
pushed a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 30, 2021
DavoudEshtehari
pushed a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 30, 2021
DavoudEshtehari
pushed a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 30, 2021
DavoudEshtehari
pushed a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 30, 2021
DavoudEshtehari
added a commit
that referenced
this pull request
Sep 3, 2021
JRahnama
pushed a commit
that referenced
this pull request
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of issue #971: The cached status of an async operation that is kept in the related connection didn't reset to be ready for the next operation.