-
Notifications
You must be signed in to change notification settings - Fork 282
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes "InvalidOperationException" errors by performing async operatio…
…ns in SemaphoreSlim (#796)
- Loading branch information
1 parent
f0572f3
commit cde615e
Showing
10 changed files
with
201 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIStreams.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.Net.Security; | ||
| using System.IO; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
| using System.Net.Sockets; | ||
|
|
||
| namespace Microsoft.Data.SqlClient.SNI | ||
| { | ||
| /// <summary> | ||
| /// This class extends SslStream to customize stream behavior for Managed SNI implementation. | ||
| /// </summary> | ||
| internal class SNISslStream : SslStream | ||
| { | ||
| private readonly ConcurrentQueueSemaphore _writeAsyncSemaphore; | ||
| private readonly ConcurrentQueueSemaphore _readAsyncSemaphore; | ||
|
|
||
| public SNISslStream(Stream innerStream, bool leaveInnerStreamOpen, RemoteCertificateValidationCallback userCertificateValidationCallback) | ||
| : base(innerStream, leaveInnerStreamOpen, userCertificateValidationCallback) | ||
| { | ||
| _writeAsyncSemaphore = new ConcurrentQueueSemaphore(1); | ||
| _readAsyncSemaphore = new ConcurrentQueueSemaphore(1); | ||
| } | ||
|
|
||
| // Prevent ReadAsync collisions by running the task in a Semaphore Slim | ||
| public override async Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken) | ||
| { | ||
| await _readAsyncSemaphore.WaitAsync(cancellationToken).ConfigureAwait(false); | ||
| try | ||
| { | ||
| return await base.ReadAsync(buffer, offset, count, cancellationToken).ConfigureAwait(false); | ||
| } | ||
| finally | ||
| { | ||
| _readAsyncSemaphore.Release(); | ||
| } | ||
| } | ||
|
|
||
| // Prevent the WriteAsync collisions by running the task in a Semaphore Slim | ||
| public override async Task WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken) | ||
| { | ||
| await _writeAsyncSemaphore.WaitAsync(cancellationToken).ConfigureAwait(false); | ||
| try | ||
| { | ||
| await base.WriteAsync(buffer, offset, count, cancellationToken).ConfigureAwait(false); | ||
| } | ||
| finally | ||
| { | ||
| _writeAsyncSemaphore.Release(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// This class extends NetworkStream to customize stream behavior for Managed SNI implementation. | ||
| /// </summary> | ||
| internal class SNINetworkStream : NetworkStream | ||
| { | ||
| private readonly ConcurrentQueueSemaphore _writeAsyncSemaphore; | ||
| private readonly ConcurrentQueueSemaphore _readAsyncSemaphore; | ||
|
|
||
| public SNINetworkStream(Socket socket, bool ownsSocket) : base(socket, ownsSocket) | ||
| { | ||
| _writeAsyncSemaphore = new ConcurrentQueueSemaphore(1); | ||
| _readAsyncSemaphore = new ConcurrentQueueSemaphore(1); | ||
| } | ||
|
|
||
| // Prevent ReadAsync collisions by running the task in a Semaphore Slim | ||
| public override async Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken) | ||
| { | ||
| await _readAsyncSemaphore.WaitAsync(cancellationToken).ConfigureAwait(false); | ||
| try | ||
| { | ||
| return await base.ReadAsync(buffer, offset, count, cancellationToken).ConfigureAwait(false); | ||
| } | ||
| finally | ||
| { | ||
| _readAsyncSemaphore.Release(); | ||
| } | ||
| } | ||
|
|
||
| // Prevent the WriteAsync collisions by running the task in a Semaphore Slim | ||
| public override async Task WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken) | ||
| { | ||
| await _writeAsyncSemaphore.WaitAsync(cancellationToken).ConfigureAwait(false); | ||
| try | ||
| { | ||
| await base.WriteAsync(buffer, offset, count, cancellationToken).ConfigureAwait(false); | ||
| } | ||
| finally | ||
| { | ||
| _writeAsyncSemaphore.Release(); | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.