[3.0] Windowing Rewrite #2278
Merged
[3.0] Windowing Rewrite #2278
+75,435
−37,459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perksey
commented
Feb 2, 2025
sources/Windowing/Windowing/Implementations/SDL3/SdlSurfaceComponents.OpenGL.cs
Outdated
Show resolved
Hide resolved
sources/Windowing/Windowing/Implementations/SDL3/SdlSurfaceComponents.OpenGL.cs
Show resolved
Hide resolved
|
@curin Ready for review. Obviously see above for things that I know I want to look at. Will fix before merge. |
|
Will update to SDL 3.2 after merge |
|
Last self-review comments have now been addressed. |
curin
reviewed
Feb 9, 2025
curin
reviewed
Feb 9, 2025
curin
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
A work-in-progress rewrite and design for windowing in 3.0.
Related issues, Discord discussions, or proposals
https://discord.com/channels/521092042781229087/587346162802229298/1281715720186626079
https://github.com/dotnet/Silk.NET/blob/main/documentation/proposals/Proposal%20-%20Windowing%203.0.md
Further Comments
None