-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Input.Common #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perksey
reviewed
Jul 12, 2019
Perksey
requested changes
Jul 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a big review, but really most of them are just suggested changes that you can apply automagically if you please. I'm not harsh on you :)
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Co-Authored-By: Dylan Perks <dylanperks23@gmail.com>
Perksey
approved these changes
Jul 13, 2019
silkdotnet
pushed a commit
that referenced
this pull request
Feb 12, 2024
…Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024
silkdotnet
pushed a commit
that referenced
this pull request
Feb 12, 2024
…P Wed Jan 10 22:57:03 UTC 2024
silkdotnet
pushed a commit
that referenced
this pull request
Apr 18, 2024
…untu SMP Thu Mar 21 16:45:46 UTC 2024
Perksey
pushed a commit
that referenced
this pull request
Apr 18, 2024
* New binaries for SwiftShader on Darwin 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:10:50 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_VMAPPLE * New binaries for SwiftShader on Microsoft Windows 10.0.20348 * New binaries for SwiftShader on Linux 6.5.0-1018-azure #19~22.04.2-Ubuntu SMP Thu Mar 21 16:45:46 UTC 2024 --------- Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
silkdotnet
pushed a commit
that referenced
this pull request
Apr 18, 2024
…Ubuntu SMP Thu Mar 21 16:45:46 UTC 2024
silkdotnet
pushed a commit
that referenced
this pull request
Apr 18, 2024
…untu SMP Thu Mar 21 16:45:46 UTC 2024
Perksey
pushed a commit
that referenced
this pull request
Apr 21, 2024
* Native: Also include *.json files in PRs (e.g. vk_swiftshader_icd.json). * Native/SwiftShader: Update submodule to 764410d. * Native/SwiftShader: Build for win-arm64. * Native/SwiftShader: Update packaging paths in Silk.NET.Vulkan.SwiftShader.Native. This was missed in #2049. * Native/Vulkan Loader: Build for win-arm64. Vulkan Loader has GAS-style assembly that is essential to it functioning correctly, so to make things simple, we build on Linux using llvm-mingw. * Native/SwiftShader: Expand on a comment in the NUKE build script. * Native: Use absolute tool paths in aarch64-w64-mingw32.cmake. * Native: Re-run CMake-based workflows when build/cmake/* changes are pushed. * Native/Vulkan Loader: Remove llvm-mingw archive after extraction. * Native/Vulkan Loader: Pass extra glob path to the win-arm64 binary. This is needed since the default globs only include *.so on Linux. * New binaries for SwiftShader on Darwin 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:10:50 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_VMAPPLE * Native/Vulkan Loader: Update submodule to v1.3.281. This brings it in line with our Vulkan-Headers submodule. * Native/Vulkan-Loader: Update submodule to 6d9e995. This brings in a number of build system fixes that we need for win-arm64. This commit is just prior to the update to Vulkan v1.3.282. * Native/Vulkan Loader: Fix path to vulkan-1.dll for win-arm64. * New binaries for SwiftShader on Microsoft Windows 10.0.20348 * Native/Vulkan Loader: Fix path to vulkan-1.dll for win-arm64, take 2. * New binaries for Vulkan Loader on Darwin 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:10:50 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_VMAPPLE * New binaries for Vulkan Loader on Linux 6.5.0-1018-azure #19~22.04.2-Ubuntu SMP Thu Mar 21 16:45:46 UTC 2024 * New binaries for Vulkan Loader on Microsoft Windows 10.0.20348 * New binaries for SwiftShader on Linux 6.5.0-1018-azure #19~22.04.2-Ubuntu SMP Thu Mar 21 16:45:46 UTC 2024 * Native: Simplify `git add` glob for changed native binaries. * Native: Simplify NuGet packaging projects. * Native: Set CMAKE_ASM_COMPILER in all toolchain files. --------- Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
silkdotnet
pushed a commit
that referenced
this pull request
Apr 22, 2024
…MP Thu Mar 21 16:45:46 UTC 2024
Perksey
pushed a commit
that referenced
this pull request
Apr 23, 2024
* Native/CMake: Configure all binutils tools in toolchain files for good measure. * Native/Vkd3d: Fix source repository URL to match submodule. * Native/Vkd3d: Clean up build script and build for linux-arm and linux-arm64. * Native: Don't install pkg-config explicitly in workflows. It's already preinstalled. * Native/wgpu-native: Add a clarifying comment to the workflow. * Native/Vkd3d: Use x86_64-w64-mingw32-widl as IDL compiler. Should avoid having to install all of Wine. * Native/Vkd3d: Temporarily patch out the Vulkan library check in configure.ac. * Native/Vkd3d: Perform configure.ac patching before invoking autogen.sh. * New binaries for Vkd3d on Linux 6.5.0-1018-azure #19~22.04.2-Ubuntu SMP Thu Mar 21 16:45:46 UTC 2024 * Revert "Native/Vkd3d: Fix source repository URL to match submodule." This reverts commit d5949f0. --------- Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
silkdotnet
pushed a commit
that referenced
this pull request
May 14, 2024
…SMP Thu Mar 21 16:45:46 UTC 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Add documentation to Input.Common, as of right now everything is completely undocumented.
Related issues, Discord discussions, or proposals
None.
Further Comments