Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some punctuation stops translation in Google Lite #616

Closed
tkefauver opened this issue Dec 1, 2023 · 4 comments
Closed

Some punctuation stops translation in Google Lite #616

tkefauver opened this issue Dec 1, 2023 · 4 comments

Comments

@tkefauver
Copy link
Contributor

Important
Read https://github.com/dotnet/ResXResourceManager/blob/master/Documentation/Topics/Troubleshooting.md first.
Problems listed there are bugs in Visual Studio and should be reported to Microsoft, not here.

Describe the bug
Some punction halts translation, I've tested with these en-US characters: !.| (exclamation point, period and pipe)

To Reproduce
Select Google Lite and attempt to translate Hey! This is a test to zh-CN

Expected behavior
The output should be (according to https://translate.google.com):
嘿! 这是一个测试

But the actual output is:
嘿!

@tom-englert
Copy link
Collaborator

Looks like this is a limitation of Google Lite, not RXRM:
image
We can only show what the provider returns.

@tkefauver
Copy link
Contributor Author

That's lame! Thanks for looking at it though :)

@tkefauver
Copy link
Contributor Author

Hi again, wanted to let you know I found a different Google translate endpoint that doesn't have this flaw! Its mentioned here: ssut/py-googletrans#268.

@tkefauver
Copy link
Contributor Author

@tom-englert Just realized this was closed, I can submit a PR using the updated endpoint. Just let me know!

tkefauver added a commit to tkefauver/ResXResourceManager that referenced this issue Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants