AddDataPartReferenceRelationshipInternal fix #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
requested changes
Jun 24, 2021
Co-authored-by: Taylor Southwick <tasou@microsoft.com>
twsouthwick
approved these changes
Jul 20, 2021
|
|
||
| // Additional test for related 1issue #949 | ||
| // Verify that the id requested in AddDataPartReferenceRelationship was used. | ||
| var mediaDataPart = new MediaDataPart(ppt.InternalOpenXmlPackage, MediaDataPartType.Mp3); |
There was a problem hiding this comment.
can you make this a separate test now that you're updating the file itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix AddDataPartReferenceRelationshipInternal call to system.io.packaging createrelationship to pass on id if available.