OpenXmlElement.CreateXmlReader: Prevent XmlConvertingReaderFactory from using a disposed TextReader #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om using a disposed XmlReader
|
|
sorensenmatias
changed the title
twsouthwick
requested changes
Jun 8, 2021
|
/azp run |
|
@twsouthwick I added a test that shows the problem I encountered, and confirms the fix. |
|
Is there anything else I can help with to get this merged? |
|
/azp run |
|
@sorensenmatias I've been pretty busy and so the delay is on me here. Once the tests pass, this can be merged in. Thanks for the contribution! |
|
/azp run |
twsouthwick
previously approved these changes
Jun 24, 2021
|
Thanks @twsouthwick. I am not sure I completely follow though, is there a problem with the tests currently? |
|
Yeah - we have warnings as error on, and there's a style warning that's getting flagged |
|
/azp run |
|
I've pushed a fix for it (needed to add a copyright) |
|
Thanks. I fixed one more warning regarding UTF8 BOM. |
|
/azp run |
twsouthwick
approved these changes
Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenXmlElement.CreateXmlReader: Prevent XmlConvertingReaderFactory from using a disposed TextReader.