Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete SaveAs #1378

Merged
merged 3 commits into from
Apr 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Marked `OpenXmlSimpleType.TextValue` as obsolete. This property was never meant to be used externally (#1284)
- Marked `OpenXmlPackage.Package` as obsolete. This will be an implementation detail in future versions and won't be accessible (#1306)
- Marked `OpenXmlPackage.Close` as obsolete. This will be removed in a later release, use Dispose instead (#1371)
- Marked `OpenXmlPackage.SaveAs` as obsolete as it will be removed in a future version (#1378)

## [2.19.0]

Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<IsShipped>false</IsShipped>
<NoWarn>$(NoWarn);SA0001</NoWarn>
<NoWarn>$(NoWarn);SA0001;CS0618</NoWarn>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>

<!-- Because of the size of the project, to facilitate quick development, by default only single
Expand Down
1 change: 1 addition & 0 deletions src/DocumentFormat.OpenXml/Packaging/OpenXmlPackage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,7 @@ public void Save()
/// </remarks>
/// <param name="path">The path and file name of the target document.</param>
/// <returns>The cloned OpenXml package</returns>
[Obsolete("This API will be removed in future release. Instead, use Clone() as it does the same thing")]
public OpenXmlPackage SaveAs(string path)
{
return Clone(path);
Expand Down