You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the SVGExample currently added in PR #1087, this pull request adds corresponding examples that demonstrate two approaches:
the Linq-to-XML way of creating markup, using the Linq-to-XML feature provided by DocumentFormat.OpenXml.Linq and
a strongly-typed way of creating markup that is closer to how you would do it in the Linq-to-XML way.
Let's discuss how we deal with the strongly-typed example. We can do multiple things. Firstly, we could demonstrate different code styles developers can use. Secondly, we could replace the original one with this one.
By the way, I am still using Visual Studio 2019, which is the reason for the initial changes in the solution file. I'm not sure whether that is an issue. One issue, however, is that you've used language version 10.0, which requires .NET 6.0, which requires Visual Studio 2022, which not everybody might have. I'm not sure whether you are using the very latest language features and whether this is really required.
@mikeebowen, if we keep both your original SVGExample (see samples/SVGExample/Program.cs in your PR) and the example provided by the StronglyTypedTools class, would it make sense for you to consider some features that I included in my example? For example:
The creation ID is not a fixed string (GUID in curly braces) but created as a unique ID for each image. Your example suggests it might be a fixed string.
The image size and position are not fixed but derived from the slide height. This is optional. However, it shows that developers need to think about sizing and positioning.
Yes, I'm using C# 10 features such as latest code generator stuff as well as the .NET 6 SDK (which has other goodness besides just C# 10 stuff and .NET 6 support - it has build time improvements I want to take advantage of). Generally, I keep the repo using the latest tool chains and will adopt that as useful. The resulting builds will still work as-is, but want to be able to use the latest as soon as possible :)
LGTM. My only concern is if the image is ok to store in the repo (not sure about licensing of images)
I took a free image from https://freesvg.org/. They seemingly have no copyright and come with the CC0 1.0 Universal (CC0 1.0)
Public Domain Dedication. However, I could take any other image with copyright by MS that you might have.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThomasBarnekow
force-pushed
the
feature/linq-to-xml-example
branch
from
Based on the SVGExample currently added in PR #1087, this pull request adds corresponding examples that demonstrate two approaches:
DocumentFormat.OpenXml.LinqandLet's discuss how we deal with the strongly-typed example. We can do multiple things. Firstly, we could demonstrate different code styles developers can use. Secondly, we could replace the original one with this one.
By the way, I am still using Visual Studio 2019, which is the reason for the initial changes in the solution file. I'm not sure whether that is an issue. One issue, however, is that you've used language version 10.0, which requires .NET 6.0, which requires Visual Studio 2022, which not everybody might have. I'm not sure whether you are using the very latest language features and whether this is really required.