Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-route calls to GitExtensions.GitIdAsVersion, GetVersionHeight to VersionOracle #527

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Re-route calls to GitExtensions.GitIdAsVersion, GetVersionHeight to VersionOracle #527

merged 3 commits into from
Oct 31, 2020

Conversation

qmfrederik
Copy link
Contributor

  • Update unit tests in GitExtensionsTests which excercise GitIdAsVersion to test VersionOracle.Version instead
  • Update unit tests in GitExtensionsTests which excercise GetVersionHeight to test VersionOracle.VersionHeight instead

As per discussion in #524, a follow-up PR can move these tests to the VersionOracleTests class.

Contributes toward #505, #521 by making it easier to unit-test a managed implementation of the VersionOracle class.

@qmfrederik qmfrederik mentioned this pull request Oct 27, 2020
Merged
12 tasks
AArnott
AArnott approved these changes Oct 31, 2020
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AArnott AArnott merged commit ec9f32e into dotnet:master Oct 31, 2020
@qmfrederik qmfrederik mentioned this pull request Oct 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qmfrederik @AArnott