Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet.Config and 'source' options for detection of latest stable version #494

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

schoeffj
Copy link
Contributor

@schoeffj schoeffj commented Aug 4, 2020

As discussed in PR #493, this PR extends the ngbv install command by the usage of all the package sources from the NuGet.Config files or, alternatively, the given source options during the detection of the latest stable version of Nerdbank.GitVersioning.

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much.

@AArnott AArnott merged commit 959eb35 into dotnet:master Aug 5, 2020
@schoeffj
Copy link
Contributor Author

schoeffj commented Aug 6, 2020

@AArnott You're welcome! Can please give me a rough estimate of when a new version of nbgv will be available? - Thanks!

@AArnott
Copy link
Collaborator

AArnott commented Aug 6, 2020

@schoeffj You can get it right now from our CI feed.
Perhaps the alternate feed doesn't bother you since you prefer to specify the -source anyway, but if you'd prefer an expedited push to nuget.org, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants