Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version.schema.json is UTF-8 with BOM, VSCode expects no BOM #839

Closed
amis92 opened this issue Oct 14, 2022 · 2 comments · Fixed by #841
Closed

version.schema.json is UTF-8 with BOM, VSCode expects no BOM #839

amis92 opened this issue Oct 14, 2022 · 2 comments · Fixed by #841

Comments

@amis92
Copy link
Contributor

amis92 commented Oct 14, 2022

Description

Visual Studio Code complains that the version.schema.json file contains a BOM, when referencing https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/main/src/NerdBank.GitVersioning/version.schema.json as $schema.

Impact

Currently, just a warning squiggle is shown, but the schema is correctly resolved and intellisense works.
I do not know whether this will work in future, but for now it's just irritating to see warnings when everything is actually fine.

image

Suggested Solution

Remove BOM from the version.schema.json. It shouldn't negatively impact any tooling.

amis92 added a commit to amis92/Nerdbank.GitVersioning that referenced this issue Oct 14, 2022
@AArnott
Copy link
Collaborator

AArnott commented Oct 14, 2022

Thanks for investigating and fixing this. I have seen the warning squiggle in VS Code many times but never hovered over it to discover what exactly it was complaining about.
I don't object to the fix, but I think it's super lame that VS Code complains about this (even though it is actually supported), so I'll file a bug against VS Code too.

@AArnott
Copy link
Collaborator

AArnott commented Oct 14, 2022

Filed microsoft/vscode#163683.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants