-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibGit2Sharp not working on sdk:2.2.105-alpine3.9 #314
Comments
Works fine with |
Hoping this is fixed by #316 |
This does not appear to have been fixed by #316 😢 . Here is how I tested locally:
But still get:
|
It looks like the alpine-x64 libgit2 lib has a dependency on openssl 1.0, which alpine 3.8 has, but alpine 3.9 updated to 1.1. binary dependencies:
https://pkgs.alpinelinux.org/packages?name=openssl&branch=v3.8 https://pkgs.alpinelinux.org/packages?name=openssl&branch=v3.9 @bording, any chance we can get native libgit2 binaries that separate out the two? |
😢 Yeah, looks like we'll need new binaries as long as we've got the OpenSSL dependency. So many headaches because of that. At least we were able to get rid of curl. I'll try and get a preview package out this weekend. |
I was surprised by the openssl dependency with curl gone. It would be amazing if the openssl dependency could be removed too. |
The problem is that libgit2 requires it to be able to talk to https remotes. The only way we'd realistically be able to drop it from LibGit2Sharp would be to compile libgit2 without https support, and then implement the support in managed code instead using the hooks libgit2 has for custom transports. There are concerns that it would be noticeably slower, though. Doing that would drastically simplify the native binaries story though. At that point the only real dependency we'd be impacted by is what libc a distro uses. |
Give LibGit2Sharp 0.27.0-preview-0007 a try. The native binaries package it references includes an |
…image instead of the SDK image. This brings the final image size to 230MB down from 1.8GB. Tried using alpine but ran into libgit2 issues (maybe related to dotnet/Nerdbank.GitVersioning#314 )
…image instead of the SDK image. This brings the final image size to 230MB down from 1.8GB. Tried using alpine but ran into libgit2 issues (maybe related to dotnet/Nerdbank.GitVersioning#314 )
Steps to reproduce:
Error:
The text was updated successfully, but these errors were encountered: