Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $schema in generate version.json from nbgv install #312

Closed
aidapsibr opened this issue Mar 26, 2019 · 2 comments
Closed

Add $schema in generate version.json from nbgv install #312

aidapsibr opened this issue Mar 26, 2019 · 2 comments

Comments

@aidapsibr
Copy link

Including the schema in the default object would be handy to provide the intellisense to editors by default.
@AArnott
Copy link
Collaborator

AArnott commented Mar 26, 2019

I think we're already doing that:

https://github.com/AArnott/Nerdbank.GitVersioning/blob/01ebb81f18af1ce64659ad06267d86be96d1f8ad/src/nbgv/Program.cs#L214

What version of the nbgv global tool are you using when it doesn't work?

@aidapsibr
Copy link
Author

This was version 2.2.13

I had assumed dotnet tool install -g nbgv would update if newer version was available, bad assumption.

Confirmed this is working in 2.3.138.

Thanks!

AArnott pushed a commit that referenced this issue Dec 8, 2024
@dependabot
Bump Microsoft.NET.Test.Sdk from 17.11.1 to 17.12.0 (#312)
2d80693 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.11.1 to 17.12.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.1...v17.12.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@AArnott AArnott mentioned this issue Dec 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AArnott @aidapsibr