Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add PrivateAssets="All" #156

Closed
clairernovotny opened this issue Dec 12, 2017 · 4 comments
Closed

Automatically add PrivateAssets="All" #156

clairernovotny opened this issue Dec 12, 2017 · 4 comments

Comments

@clairernovotny
Copy link
Member

I haven't tried this yet in my Extras, but I'm about to --

Rather than having people remember to add PrivateAssets="all" to the PackageReference, if the targets has this:
https://github.com/dotnet/sdk/blob/master/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.DefaultItems.props#L53-L56

It can update the metadata automatically. There's no reason a user shouldn't have that for this package... ?

@clairernovotny
Copy link
Member Author

This works for me upon testing it :)

@clairernovotny
Copy link
Member Author

Hmm.... works for me for single target packages but fails for multi targeted ones. Haven't looked closer to see if there's a workaround.

@clairernovotny
Copy link
Member Author

I've filed this too NuGet/Home#6317

@AArnott
Copy link
Collaborator

AArnott commented Feb 20, 2018

Please post if this ends up working for multi-targeted projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants