Make test project target .net core and framework #76
Conversation
Change the test project to a dotnet core style project which targets both dotnet core and dotnet framework. Further changes: * Adapt LLVMSharp.csproj correspondingly * Remove unnecessary packages.config (package references are now in project file) and AssemblyInfo
With the older version, the project would no longer build on Windows (probably due to missing package references) after the change introduced by the last commit.
Build only LLVMSharp project intially and then run tests with explicit target framework netcoreapp2.0
This reverts commit 2cf46a4.
|
@mjsabby Is this change still relevant now that the OOAPI has been merged (for the master branch) or should I close the PR? |
Yes, I think this PR isn't relevant anymore. However, if you could find a way to move files around so that we can run the tests with just |
I suppose the problem is that |
In PR #74, @TChatzigiannakis mentioned that his tests don't work because they are no longer compatible with dotnet core. I have replaced the test project with a dotnet core style project
which targets both dotnet core and dotnet framework.
You can run the dotnet core tests with
dotnet test Tests.csproj /p:TargetFramework=netcoreapp2.0.For the dotnet framework tests, you should replace
netcoreapp2.0bynet461.