Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample projects according to the newest LLVM# API + .Net Core 2.0 #58

Merged
merged 9 commits into from
Oct 12, 2017
Merged

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Oct 11, 2017

And fix some stupid errors. 😂

@msftclas
Copy link

msftclas commented Oct 11, 2017

CLA assistant check
All CLA requirements met.

@ice1000
Copy link
Contributor Author

ice1000 commented Oct 11, 2017

I also recommend you to make the use of Travis CI.

@ice1000
Copy link
Contributor Author

ice1000 commented Oct 11, 2017

My last commit ask Travis CI to build LLVM#. Travis CI will only send you email when you pushed uncompilable code(rather than simply build fail).

@ice1000
Copy link
Contributor Author

ice1000 commented Oct 11, 2017

@mjsabby @martinwoodward 😄 Please carefully review and merge my pull request

@mjsabby
Copy link
Contributor

mjsabby commented Oct 12, 2017

@ice1000 can you squash merge into a single commit? Also, is there a reason why you removed "this." from your changes?

@ice1000
Copy link
Contributor Author

ice1000 commented Oct 12, 2017

is there a reason why you removed "this." from your changes?

It's..ahh just personal reason. I'll revert those changes.

squash

Can you do this as the merger? I've seen the github blog and it says there's a button like this

link: https://github.com/blog/2141-squash-your-commits

@ice1000
Copy link
Contributor Author

ice1000 commented Oct 12, 2017

All this. are reverted. Please check and squash merge.

@ice1000
Copy link
Contributor Author

ice1000 commented Oct 12, 2017

@mjsabby 😃 CI check done. Everything's ready

@mjsabby mjsabby merged commit c4fcf6c into dotnet:master Oct 12, 2017
@mjsabby
Copy link
Contributor

mjsabby commented Oct 12, 2017

Thanks @ice1000, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants