Get started with WPF #2535
Merged
Get started with WPF #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Jul 24, 2020
smitpatel
reviewed
Jul 24, 2020
|
@dotnet/efcore does anyone else want to review before I squash and merge? |
bricelam
approved these changes
Jul 24, 2020
Comment on lines
+45
to
+47
| // this forces the grid to refresh to latest values | ||
| categoryDataGrid.Items.Refresh(); | ||
| productsDataGrid.Items.Refresh(); |
There was a problem hiding this comment.
Shouldn't need to call these if you implement INotifyPropertyChanged. Unless we set the fields directly by default, in which case, you should configure EF to set via properties for the best experience.
There was a problem hiding this comment.
I added a section to explain property change notification.
samples/core/WPF/GetStartedWPF/GetStartedWPF/MainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
|
@bricelam all changes are implemented and pushed, just waiting confirmation before I squash/merge |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft for review