Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reflecting on DebuggableAttribute on CoreRT #1055

Merged
merged 2 commits into from
Feb 8, 2019
Merged

Allow reflecting on DebuggableAttribute on CoreRT #1055

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7034bba
Allow reflecting on DebuggableAttribute on CoreRT
MichalStrehovsky Feb 7, 2019
f1d0471
Comment
MichalStrehovsky Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/BenchmarkDotNet/Toolchains/CoreRt/Generator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ private string GenerateProjectForLocalBuild(BuildPartition buildPartition, Artif
</Project>";

/// <summary>
/// mandatory to make it possible ot call GC.GetAllocatedBytesForCurrentThread() using reflection (not part of .NET Standard)
/// mandatory to make it possible to call GC.GetAllocatedBytesForCurrentThread() using reflection (not part of .NET Standard)
/// and DebuggableAttribute.
/// </summary>
private void GenerateReflectionFile(ArtifactsPaths artifactsPaths)
{
Expand All @@ -184,6 +185,7 @@ private void GenerateReflectionFile(ArtifactsPaths artifactsPaths)
<Application>
<Assembly Name=""System.Runtime"">
<Type Name=""System.GC"" Dynamic=""Required All"" />
<Type Name=""System.Diagnostics.DebuggableAttribute"" Dynamic=""Required All"" />
</Assembly>
</Application>
</Directives>
Expand All @@ -192,4 +194,4 @@ private void GenerateReflectionFile(ArtifactsPaths artifactsPaths)
File.WriteAllText(Path.Combine(Path.GetDirectoryName(artifactsPaths.ProjectFilePath), "rd.xml"), content);
}
}
}
}