-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Include not-lastest-version: Part 1: client-side to grpc folders #33124
Conversation
Closing and reopening for a fresh build. |
@Rick-Anderson or @tdykstra , I am getting blocking build warnings on the aspnetcore/includes/not-latest-version.md itself. Am I inserting or using it in a way that it was not intended possibly? Or perhaps we are just getting new build check warnings on that include we did not get before? |
@guardrex, you have been using this not-latest-version include for blazor content successfully. I don't know the history on it. Was it intended to included only for very for specific versions of doc with specific ranges? See the build errors on this PR. |
I had the same error and @tdykstra showed me how to fix it. I don't remember the fix. |
I'm not sure that the current approach that was taken with the INCLUDE file can ever work. I don't think it can be used in files that are versioned for the current release (or later). What I think is happening is that ...
What I do is leave it in place commented out with a searchable comment for activation at the next GA. For example ... https://github.com/dotnet/AspNetCore.Docs/edit/main/aspnetcore/blazor/components/sections.md When 9.0 comes out and I search "UPDATE 9.0" in the Blazor node (which will return a bunch of little things that I need to do around the Blazor docs when I'm working 9.0 tasks), I activate them (remove the comment). Any articles versioned >=9.0 won't be able to activate the INCLUDE until 10.0 releases. Therefore, I'm making it work by not using it for current or future release docs, and that's the only way that I think it can work in its current form. Tom is aware of this because I see that he took a similar approach in ... https://github.com/dotnet/AspNetCore.Docs/edit/main/aspnetcore/performance/caching/hybrid.md ... and he took the further step of surfacing the preview remark with ... [!INCLUDE[](~/includes/not-ga-yet.md)] ... which is something that I'm not currently doing but could do in the future. |
After discussing with TDykstra and including gaurdrex helpful info, it sounds like there are 3 conditions involved: If the doc meta data at the top of the page has a monikerRange of: Then insert this just below the H1 (#):
If the doc meta data at the top of the page has a monikerRange of: Then insert this just below the H1 (#)
If the doc meta data at the top of the page has a monikerRange that is anything <8.0:
|
I will close this and do a much smaller number of files at a time until I am confident it all seems to work. Thanks everyone for the help. I wasn't catching on this still might be a bit experimental yet. |
That all sounds right to me. The only piece that I'm not doing right now is the |
Contributes to fixing #32886
1st of a few PR's. This PR covers folders of content in alpha order from client-side to grpc. 148 files.
[!INCLUDE[](~/includes/not-latest-version.md)]
was inserted with one blank line above and below it existing after the edit.Only files that met all of the following conditions received the inserted text:
[!INCLUDE[](~/includes/not-latest-version.md)]
in it.Internal previews
Toggle expand/collapse
ValueTask<T>
.Note
This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.