Skip to content

Commit

Permalink
Merged PR 60158: Delete CreateDummyCartInsightData.php
Browse files Browse the repository at this point in the history
## What's being changed

We're removing a data patch that made a request to Dotdigital.

## Why it's being changed

Dummy data is sent at account connection. This patch was created so that merchants on older than v4.5.3 would have this collection created without having to re-save their account details.

This carries the risk that merchants applying the patch at install may not yet have connected a DD account - in which case the request will fail, the script will try to log the error, and we may see errors relating to Logger like:
```
Unable to apply data patch Dotdigitalgroup\Email\Setup\Patch\Data\CreateDummyCartInsightData for module Dotdigitalgroup_Email. Original exception message: Missing required argument $name of Dotdigitalgroup\Email\Logger\Logger.
```

Merchants upgrading from <4.5.3 would simply need to re-save their account credentials to send dummy data to the platform.

## How to review / test this change

- Green builds in the pipelines should indicate that the module can still be installed/upgraded as expected

Related work items: #278925
  • Loading branch information
sta1r committed Dec 2, 2024
1 parent 29d65de commit ce239a5
Showing 1 changed file with 0 additions and 67 deletions.
67 changes: 0 additions & 67 deletions Setup/Patch/Data/CreateDummyCartInsightData.php

This file was deleted.

0 comments on commit ce239a5

Please sign in to comment.