Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented tests, code sniffer, psalm and laminas coding standard #25

Merged
merged 6 commits into from
Jul 28, 2023

Conversation

pinclau
Copy link
Member

@pinclau pinclau commented Jul 26, 2023

@alexmerlin please review this
related to #24 #23

This was linked to issues Jul 26, 2023
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
test/SessionMiddlewareTest.php Show resolved Hide resolved
test/Factory/SessionMiddlewareFactoryTest.php Show resolved Hide resolved
test/Factory/SessionMiddlewareFactoryTest.php Show resolved Hide resolved
test/Factory/SessionOptionsFactoryTest.php Show resolved Hide resolved
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 unresolved items, please fix them and see my comment on README.md.

README.md Show resolved Hide resolved
@alexmerlin alexmerlin merged commit f5ab5ad into dotkernel:5.0 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

green badge Code quality
2 participants