Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #75: Replaced Psalm with PHPStan #76

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Issue #75: Replaced Psalm with PHPStan #76

merged 3 commits into from
Feb 21, 2025

Conversation

alexmerlin
Copy link
Member

No description provided.

Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
@alexmerlin alexmerlin self-assigned this Feb 20, 2025
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
@alexmerlin alexmerlin linked an issue Feb 20, 2025 that may be closed by this pull request
@alexmerlin alexmerlin requested a review from arhimede February 20, 2025 14:56
@arhimede
Copy link
Member

uh oh, that many changes in files ?
That many differences between phpstan and psalm ?

@alexmerlin
Copy link
Member Author

uh oh, that many changes in files ? That many differences between phpstan and psalm ?

It depends on the package size, some might require less changes, others may require even more.

Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (5.0@aaf3967). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Logger.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             5.0      #76   +/-   ##
======================================
  Coverage       ?   75.53%           
  Complexity     ?      332           
======================================
  Files          ?       27           
  Lines          ?      789           
  Branches       ?        0           
======================================
  Hits           ?      596           
  Misses         ?      193           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arhimede arhimede merged commit 6944caa into 5.0 Feb 21, 2025
40 checks passed
@alexmerlin alexmerlin deleted the issue-75 branch February 21, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Psalm with PHPStan
2 participants