Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed with Xcode 9 beta 6 #135

Closed
jamescoletti opened this issue Sep 1, 2017 · 9 comments
Closed

Build failed with Xcode 9 beta 6 #135

jamescoletti opened this issue Sep 1, 2017 · 9 comments

Comments

@jamescoletti
Copy link

Is this project compatible with Xcode 9 beta yet? At the very least, the build seems to fail in the RxBluetooth iOS dependency, which is set at 3.0.12, and it appears there have been some Xcode 9 beta related fixes in 3.0.14.

@jamescoletti
Copy link
Author

FYI - I was able to get everything working by:

  1. Bumping the RxBluetooth dependency version from 3.0.12 to 3.0.14
  2. Changing the #import statements per PR Add <React/ prefix to React imports #136

Using react-native@0.48.1 and react-native-ble-plx@0.6.1

mmerickel added a commit to mmerickel/react-native-ble-plx that referenced this issue Sep 19, 2017
mmerickel added a commit to mmerickel/react-native-ble-plx that referenced this issue Sep 20, 2017
@mmerickel
Copy link
Contributor

I can confirm this fixed my issues for now as well.

@SchwarzerSchnee
Copy link

Doesn't work for me because I'm getting the files to be changed only with npm install, but they'll be deleted right again upon failure.

@jamescoletti
Copy link
Author

@SchwarzerSchnee you could fork the repo, make the changes, and then npm install your forked version. Or for a quick-and-dirty solution after install failure, you could probably update the versions in the Cartfile in ios/BleClientManager, delete the Carthage folder there, and run bash build_ios_frameworks.sh.

@wkoutre wkoutre mentioned this issue Sep 22, 2017
@SchwarzerSchnee
Copy link

Thank you, that works for now but still it's kinda dirty to have a local dependency that shouldn't be there. Here's hoping the issue gets fixed entirely on the lib's end eventually, since Xcode 9 has been officially released now.

@Cierpliwy
Copy link
Contributor

Yesterday I downloaded XCode 9, so hopefully I'll release fixes and new features this week with 0.7.0 version. Sorry for delay.

@fisehara
Copy link

Confirm changes to :
Carfile: Github "Polidea/RxBluetoothKit" "3.0.14"
Cartfile.resolved: github "Polidea/RxBluetoothKit" "3.0.14"

solved my issue as well

@Cierpliwy
Copy link
Contributor

This issue should be resolved with version 0.6.2.

@jamescoletti
Copy link
Author

Thanks @Cierpliwy! I can confirm 0.6.2 is building successfully in Xcode 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants