Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validation rule for defer/stream support #1987

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Nov 1, 2022

bring in validation rules for defer stream graphql/graphql-js#3659

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2022

🦋 Changeset detected

Latest commit: 38fc442

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
graphql-yoga Minor
@graphql-yoga/common Patch
@graphql-yoga/node Patch
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-prometheus Major
@graphql-yoga/plugin-response-cache Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
hackernews Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 105502      ✗ 0    
     data_received..................: 16 MB   524 kB/s
     data_sent......................: 6.1 MB  202 kB/s
     http_req_blocked...............: avg=1.98µs   min=1.2µs    med=1.7µs    max=561.81µs p(90)=2.29µs   p(95)=2.6µs   
     http_req_connecting............: avg=2ns      min=0s       med=0s       max=157.2µs  p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=455.78µs min=286.81µs med=381.41µs max=24.32ms  p(90)=546.41µs p(95)=689.82µs
       { expected_response:true }...: avg=455.78µs min=286.81µs med=381.41µs max=24.32ms  p(90)=546.41µs p(95)=689.82µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 52751
     http_req_receiving.............: avg=29.48µs  min=17.2µs   med=23.9µs   max=6.1ms    p(90)=37.5µs   p(95)=43.9µs  
     http_req_sending...............: avg=10.8µs   min=6.1µs    med=7.8µs    max=4.83ms   p(90)=17.4µs   p(95)=19.9µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=415.49µs min=258.3µs  med=346.91µs max=24.13ms  p(90)=491.31µs p(95)=628.92µs
     http_reqs......................: 52751   1758.273125/s
     iteration_duration.............: avg=561.81µs min=359.81µs med=483.41µs max=25.13ms  p(90)=676.42µs p(95)=833.82µs
     iterations.....................: 52751   1758.273125/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/redis-event-target 1.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/typed-event-target 1.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 3.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
graphql-yoga 3.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 1.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎
@graphql-yoga/subscription 3.0.0-alpha-20221101184927-33ad31da npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://fe7cf1b4.graphql-yoga.pages.dev

@ardatan ardatan merged commit 5568e4c into v3 Nov 1, 2022
@ardatan ardatan deleted the saihaj/validation-rules-defer-stream branch November 1, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants