-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@graphql-codegen/cli >= 2.13.10 causes "Unknown fragment" error #8570
Comments
I've just run into this too. I reverted back to my previous .8 install and things are fine. |
Same same |
Just hit this as well – good to know I'm not crazy 😅 |
Still getting this on 2.13.11 (upgrading from 2.13.8) |
Same here. |
Hi everyone! Very sorry for this regression introduced in a great performance improvement of codegen validations (now 40x faster) 🏎️ It is now fixed in |
still broken in version 4 in certain cases. EDIT: ok, in my case it was silly: make sure that the file containing your fragment has no syntax errors. Not only look at the fragment query, but also at the rest of the code. Any javascript / typescript error can break it |
well it works |
- Thumbnail being js somehow break codegen extraction in CooccurrenceSection - Ref: dotansimha/graphql-code-generator#8570 (comment) - remove `??` to make old prettier happy
I encountered "Unknown fragment" issue when a Ref: cofacts/rumors-site@e5d9c5d
Error got away after I change |
Describe the bug
Broken sandbox:
https://codesandbox.io/s/gql-codegen-fragment-error-reversion-narrow-dep-mtze4x?file=/package.json
Working sandbox:
https://codesandbox.io/s/gql-codegen-fragment-error-reversion-working-9j9i6q?file=/package.json
Your Example Website or App
https://codesandbox.io/s/gql-codegen-fragment-error-reversion-narrow-dep-mtze4x?file=/package.json
Steps to Reproduce the Bug or Issue
yarn generate
Expected behavior
I expect
@graphql-codegen/cli >= 2.13.10
to work like previous versions.Screenshots or Videos
No response
Platform
see codesandbox
Codegen Config File
default codesandbox file
Additional context
This has been working fine and I was surprised with a fresh
ncu -u && yarn install
with only patch releases updated that my codegen is broken. I've narrowed the test sandbox down to @graphql-codegen/cli@2.13.9 being successful, and @graphql-codegen/cli@2.13.10 failing.The text was updated successfully, but these errors were encountered: