Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-urql-graphcache): mark @urql/exchange-graphcache v6 compatible #361

Merged
merged 1 commit into from
Jul 20, 2023
Merged

feat(typescript-urql-graphcache): mark @urql/exchange-graphcache v6 compatible #361

merged 1 commit into from
Jul 20, 2023

Conversation

dargmuesli
Copy link
Contributor

Description

Resolves #342

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

🦋 Changeset detected

Latest commit: af92817

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-urql-graphcache Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frederikhors
Copy link

Can you please merge this ASAP, @n1ru4l? Please...

@dargmuesli
Copy link
Contributor Author

To me this contribution seems pretty cosmetic. Maybe give a reason why there is a need to rush? 😄

@frederikhors
Copy link

Maybe give a reason why there is a need to rush?

How wow - not cosmetic at all, this is the reason:

npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @graphql-codegen/typescript-urql-graphcache@2.4.5
npm ERR! Found: @urql/exchange-graphcache@6.1.0
npm ERR! node_modules/@urql/exchange-graphcache
npm ERR!   dev @urql/exchange-graphcache@"6.1.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @urql/exchange-graphcache@"^4.1.1 || ^5.0.0" from @graphql-codegen/typescript-urql-graphcache@2.4.5
npm ERR! node_modules/@graphql-codegen/typescript-urql-graphcache
npm ERR!   dev @graphql-codegen/typescript-urql-graphcache@"2.4.5" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @urql/exchange-graphcache@5.2.0
npm ERR! node_modules/@urql/exchange-graphcache
npm ERR!   peer @urql/exchange-graphcache@"^4.1.1 || ^5.0.0" from @graphql-codegen/typescript-urql-graphcache@2.4.5
npm ERR!   node_modules/@graphql-codegen/typescript-urql-graphcache
npm ERR!     dev @graphql-codegen/typescript-urql-graphcache@"2.4.5" from the root project

@dargmuesli
Copy link
Contributor Author

dargmuesli commented May 31, 2023

Looking at npm/cli#3666 and https://levelup.gitconnected.com/how-to-fix-the-npm-conflicting-peer-dependency-error-fe5527f629a4 maybe consider using pnpm or yarn instead or configure npm so that peer dependencies are not strict 💡

@frederikhors
Copy link

Looking at npm/cli#3666 maybe consider using pnpm or yarn instead or configure npm so that peer dependencies are not strict 💡

I like this npm error. It is genuinely obvious and I would like to avoid yarn or pnpm.

We just need to upgrade deps. LOL.

@dargmuesli
Copy link
Contributor Author

Yeah, but no need to be pushy about it 😄 v6 is compatible but just not marked as such yet. You can mark it as compatible yourself in package managers that support it. I'm sure people will get around to merge this PR when they have time to do so. If it takes some time, there might be more urgent tasks 🙊 also, if you really want that strictness and immediate updates at the same time, you always have the option to fork 🤙

@dargmuesli
Copy link
Contributor Author

As this project is a community project, another idea is to join that community and become a maintainer 💡

@frederikhors
Copy link

become a maintainer

how?

@dargmuesli
Copy link
Contributor Author

Introduction of the “community plugins”

...
All the above plugins will be eligible for repository ownership transfer based on relevant past contributions.

dotansimha/graphql-code-generator#9456

I'm sure dotansimha or saihaj will be able to assist with that.

@frederikhors
Copy link

frederikhors commented Jul 20, 2023

@kamilkisiela @dotansimha @dargmuesli @ardatan can you please merge this?

@dargmuesli
Copy link
Contributor Author

I do not have merge permissions, I only created the PR

@n1ru4l n1ru4l merged commit 2d3df93 into dotansimha:main Jul 20, 2023
@dargmuesli dargmuesli deleted the chore/urql-exchange-graphcache branch July 21, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support urql graphcache v6
3 participants