-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript-urql-graphcache): mark @urql/exchange-graphcache v6 compatible #361
feat(typescript-urql-graphcache): mark @urql/exchange-graphcache v6 compatible #361
Conversation
…ompatible Resolves #342
🦋 Changeset detectedLatest commit: af92817 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Can you please merge this ASAP, @n1ru4l? Please... |
To me this contribution seems pretty cosmetic. Maybe give a reason why there is a need to rush? 😄 |
How wow - not cosmetic at all, this is the reason:
|
Looking at npm/cli#3666 and https://levelup.gitconnected.com/how-to-fix-the-npm-conflicting-peer-dependency-error-fe5527f629a4 maybe consider using pnpm or yarn instead or configure npm so that peer dependencies are not strict 💡 |
I like this npm error. It is genuinely obvious and I would like to avoid yarn or pnpm. We just need to upgrade deps. LOL. |
Yeah, but no need to be pushy about it 😄 v6 is compatible but just not marked as such yet. You can mark it as compatible yourself in package managers that support it. I'm sure people will get around to merge this PR when they have time to do so. If it takes some time, there might be more urgent tasks 🙊 also, if you really want that strictness and immediate updates at the same time, you always have the option to fork 🤙 |
As this project is a community project, another idea is to join that community and become a maintainer 💡 |
how? |
dotansimha/graphql-code-generator#9456 I'm sure dotansimha or saihaj will be able to assist with that. |
@kamilkisiela @dotansimha @dargmuesli @ardatan can you please merge this? |
I do not have merge permissions, I only created the PR |
Description
Resolves #342
Type of change
Please delete options that are not relevant.
expected)
Checklist:
CONTRIBUTING doc and the
style guidelines of this project