Fix RMC FixTime parsing that can lose sub-second precision with doubles #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
AddSeconds
on theDateTimeOffset
, in .NET 6 it rounds the double to the closest millisecond value. However, this changed in .NET 7. https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/7.0/datetime-add-precisionRegardless of whether or not this package adds .NET 7 support, this change will ensure that we don't lose any subsecond precision from the NMEA message.
For NMEA messages that have less than 3 digits of precision, this will not change any behavior
"$GPRMC,141825.2,A,4249.92297,N,08548.52186,W,000.01,227.1,040322,005.5,W*54"
But for NMEA messages with more than 3 digits of precision, this will preserve that precision.
"$GPRMC,141825.1999,A,4249.92297,N,08548.52186,W,000.01,227.1,040322,005.5,W*54"