Fix empty proxy entries in Data Feeds list (smartcontractkit#1772)

* Fix empty proxy entries in Data Feeds list * Fix filter * Fix Data Streams * Lint fix
dorianbayart · Feb 22, 2024 · 28f4f3e · 28f4f3e
1 parent b9a77e9
commit 28f4f3e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 13 deletions.
diff --git a/src/features/data/api/backend.ts b/src/features/data/api/backend.ts
@@ -13,7 +13,9 @@ export const getServerSideChainMetadata = async (chains: Chain[]): Promise<Recor
             type: "json", // we’ll parse JSON for you
           }).then((metadata) => ({
             ...nw,
-            metadata: metadata.filter((meta) => meta.docs?.hidden !== true),
+            metadata: metadata.filter(
+              (meta) => meta.docs?.hidden !== true && (meta.proxyAddress || meta.transmissionsAccount || meta.feedId)
+            ),
           }))
         : undefined
     )

diff --git a/src/features/data/api/index.ts b/src/features/data/api/index.ts
@@ -48,7 +48,9 @@ export const getChainMetadata = async (chain: Chain): Promise<ChainMetadata | an
     network?.rddUrl
       ? getFeedsMetadata(network?.rddUrl).then((metadata) => ({
           ...network,
-          metadata: metadata.filter((meta) => meta.docs?.hidden !== true),
+          metadata: metadata.filter(
+            (meta) => meta.docs?.hidden !== true && (meta.proxyAddress || meta.transmissionsAccount || meta.feedId)
+          ),
         }))
       : undefined
   )

diff --git a/src/features/feeds/components/Tables.tsx b/src/features/feeds/components/Tables.tsx
@@ -348,8 +348,8 @@ const StreamsTr = ({ network, proxy, showExtraDetails }) => (
   <tr>
     <td class={tableStyles.pairCol}>
       <div className={tableStyles.assetPair}>
-        {feedCategories[proxy.docs.feedCategory] || ""}
         {proxy.pair[0]}/{proxy.pair[1]}
+        {proxy.docs.schema ? <div>Schema: {proxy.docs.schema}</div> : ""}
       </div>
       {proxy.docs.shutdownDate && (
         <div className={clsx(feedList.shutDate)}>
@@ -392,16 +392,6 @@ const StreamsTr = ({ network, proxy, showExtraDetails }) => (
       </div>
       <div>
         <dl class={tableStyles.porDl}>
-          {proxy.docs.schema ? (
-            <div>
-              <dt>
-                <span class="label">Report schema:</span>
-              </dt>
-              <dd>{proxy.docs.schema}</dd>
-            </div>
-          ) : (
-            ""
-          )}
           {proxy.docs.productType ? (
             <div>
               <dt>