-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a default configuration for integrating metrics from openshif… #995
Provide a default configuration for integrating metrics from openshif… #995
Conversation
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
1f56448
to
63da2b9
Compare
815b6d6
to
4bb6e37
Compare
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
Any idea how to deal with this? Operator from the build above is failing with:
|
I think you have an already installed Prometheus operator (this will happen to Grafana too). Run cleanup command and and uninstall the Prometheus/Operator, then run run bundle command again |
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
7fcf52e
to
97efd0f
Compare
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
@mpryc @mateusoliveira43 updated to address your comments. |
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
/retest |
/lgtm |
@mateusoliveira43 could you please review? |
From my side, I still did not test it, I am missing testing instructions in the PR description (basically, an example yaml, but in this case, what does this change adds? how do I see them in OpenShift?) |
Instructions to test.
|
@mateusoliveira43 posted testing instructions above |
Signed-off-by: Eric Sauer <esauer@redhat.com>
ae2e8a0
to
fbf87b5
Compare
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…t-monitoring
Linked Issues
Description
This change provides a default config for pulling in (federating) metrics from the openshift-monitoring instance that lives in the same cluster as Pelorus. This reduces the setup necessary to just a boolean value, rather than having to go grab passwords and store them.
Testing Instructions