Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default configuration for integrating metrics from openshif… #995

Merged

Conversation

etsauer
Copy link
Collaborator

@etsauer etsauer commented May 18, 2023

…t-monitoring

Linked Issues

Description

This change provides a default config for pulling in (federating) metrics from the openshift-monitoring instance that lives in the same cluster as Pelorus. This reduces the setup necessary to just a boolean value, rather than having to go grab passwords and store them.

Testing Instructions

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2023
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr995-ca8070c \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr995-ef0f13a \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@etsauer etsauer force-pushed the federate-openshift-monitoring branch from 1f56448 to 63da2b9 Compare May 19, 2023 01:43
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr995-b673edd \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr995-80a0699 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@etsauer
Copy link
Collaborator Author

etsauer commented May 19, 2023

Any idea how to deal with this? Operator from the build above is failing with:

        constraints not satisfiable: subscription
        prometheus-beta-community-operators-openshift-marketplace requires
        @existing/test-pelorus-operator//prometheusoperator.0.56.3, subscription
        pelorus-operator-v0-0-7-pr995-b673edd-sub exists, subscription
        pelorus-operator-v0-0-7-pr995-b673edd-sub requires
        pelorus-operator-catalog/test-pelorus-operator/operator-sdk-run-bundle/pelorus-operator.v0.0.7-pr995-b673edd,
        bundle pelorus-operator.v0.0.7-pr995-b673edd requires an operator with
        package: prometheus and with version in range: 0.47.0,
        @existing/test-pelorus-operator//prometheusoperator.0.56.3 and
        community-operators/openshift-marketplace/beta/prometheusoperator.0.47.0
        originate from package prometheus, subscription
        prometheus-beta-community-operators-openshift-marketplace exists

.gitignore Outdated Show resolved Hide resolved
@mateusoliveira43
Copy link
Collaborator

Any idea how to deal with this? Operator from the build above is failing with:

        constraints not satisfiable: subscription
        prometheus-beta-community-operators-openshift-marketplace requires
        @existing/test-pelorus-operator//prometheusoperator.0.56.3, subscription
        pelorus-operator-v0-0-7-pr995-b673edd-sub exists, subscription
        pelorus-operator-v0-0-7-pr995-b673edd-sub requires
        pelorus-operator-catalog/test-pelorus-operator/operator-sdk-run-bundle/pelorus-operator.v0.0.7-pr995-b673edd,
        bundle pelorus-operator.v0.0.7-pr995-b673edd requires an operator with
        package: prometheus and with version in range: 0.47.0,
        @existing/test-pelorus-operator//prometheusoperator.0.56.3 and
        community-operators/openshift-marketplace/beta/prometheusoperator.0.47.0
        originate from package prometheus, subscription
        prometheus-beta-community-operators-openshift-marketplace exists

I think you have an already installed Prometheus operator (this will happen to Grafana too). Run cleanup command and and uninstall the Prometheus/Operator, then run run bundle command again

@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr995-ff1b24d \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@etsauer etsauer force-pushed the federate-openshift-monitoring branch from 7fcf52e to 97efd0f Compare May 19, 2023 18:09
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr995-048a221 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@etsauer
Copy link
Collaborator Author

etsauer commented Aug 8, 2023

@mpryc @mateusoliveira43 updated to address your comments.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr995-25dd742 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@etsauer
Copy link
Collaborator Author

etsauer commented Aug 8, 2023

/retest

@mpryc
Copy link
Collaborator

mpryc commented Aug 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@mpryc
Copy link
Collaborator

mpryc commented Aug 9, 2023

@mateusoliveira43 could you please review?
@etsauer Should the title be without WIP and unhold or remove do-not-merge label?

@mateusoliveira43
Copy link
Collaborator

From my side, I still did not test it, I am missing testing instructions in the PR description (basically, an example yaml, but in this case, what does this change adds? how do I see them in OpenShift?)

@etsauer
Copy link
Collaborator Author

etsauer commented Aug 9, 2023

Instructions to test.

  1. Install the latest PR build to your cluster
  2. Apply the following Pelorus CR:
    kind: Pelorus
    apiVersion: charts.pelorus.dora-metrics.io/v1alpha1
    metadata:
      name: pelorus-sample
      namespace: test-pelorus-operator
    spec:
      federate_openshift_monitoring:
        enabled: true
        metrics_filter:
        # Just pull in one specific metric
        - 'kube_pod_container_info{}'
      exporters:
        global: {}
        instances: []
  3. Go to the pelorus-prometheus web console, and run the following query: kube_pod_container_info{}. Should get multiple results back

@etsauer
Copy link
Collaborator Author

etsauer commented Aug 9, 2023

@mateusoliveira43 posted testing instructions above

@etsauer etsauer changed the title WIP: Provide a default configuration for integrating metrics from openshif… Provide a default configuration for integrating metrics from openshif… Aug 10, 2023
@openshift-ci openshift-ci bot added dco-signoff: no and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm Indicates that a PR is ready to be merged. dco-signoff: yes labels Aug 10, 2023
Signed-off-by: Eric Sauer <esauer@redhat.com>
@etsauer etsauer force-pushed the federate-openshift-monitoring branch from ae2e8a0 to fbf87b5 Compare August 11, 2023 20:23
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr995-403bac6 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr995-3a071de \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@mpryc
Copy link
Collaborator

mpryc commented Aug 14, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 75ca146 into dora-metrics:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants