Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework of deploytime codebase #981

Merged
merged 1 commit into from
May 15, 2023
Merged

Rework of deploytime codebase #981

merged 1 commit into from
May 15, 2023

Conversation

mpryc
Copy link
Collaborator

@mpryc mpryc commented May 10, 2023 •
edited
Loading

Rework of deploytime codebase

Move functions to the common openshift library.

Optimize querying for the parent objects such as ReplicaSet and ReplicationController. With this implementation we relay on known api versions and api objects directly from the pod.

Added cache to optimize queries to the OpenShift API for the parent objects. For the running pods we do want to always have the latest state, which means we can't do caching there.

Reworked extracting image SHAs from the running pod instances, which is a base for the skopeo as we also get the full URI of the image.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-76cdfe5 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@mpryc mpryc changed the title WIP: rework of deploytime Rework of deploytime codebase May 11, 2023
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-36fd3f1 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-41c5bba \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@mateusoliveira43 mateusoliveira43 self-assigned this May 11, 2023
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-82f6999 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

mateusoliveira43
mateusoliveira43 reviewed May 11, 2023
View reviewed changes
Dockerfile_skopeo Outdated Show resolved Hide resolved
mpryc
mpryc commented May 11, 2023
View reviewed changes
Copy link
Collaborator Author

@mpryc mpryc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replied to comments and submitted new revision.

@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-bb648c1 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@mpryc mpryc force-pushed the fix_967 branch 2 times, most recently from eff2868 to 6d5cb26 Compare May 15, 2023 12:02
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-24a6548 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-d38bb54 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-9cfc94d \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@mpryc mpryc force-pushed the fix_967 branch 2 times, most recently from 20dbfe2 to 10c393e Compare May 15, 2023 14:13
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-839d32a \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@mpryc
Copy link
Collaborator Author

mpryc commented May 15, 2023

/unhold

@mpryc mpryc marked this pull request as ready for review May 15, 2023 14:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2023
@openshift-ci openshift-ci bot requested review from etsauer and weshayutin May 15, 2023 14:19
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-60908c4 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@mpryc
Rework of deploytime codebase
6f744f3 
Move functions to the common openshift library.

Optimize querying for the parent objects such as ReplicaSet
and ReplicationController. With this implementation we relay on known
api versions and api objects directly from the pod.

Added cache to optimize queries to the OpenShift API for the
parent objects. For the running pods we do want to always have
the latest state, which means we can't do caching there.

Reworked extracting image SHAs from the running pod instances,
which is a base for the skopeo as we also get the full URI of the
image.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@github-actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr981-0995cfb \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@openshift-ci
Copy link

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@mateusoliveira43
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit cf049b8 into dora-metrics:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusoliveira43 mateusoliveira43 mateusoliveira43 approved these changes

@etsauer etsauer Awaiting requested review from etsauer

@weshayutin weshayutin Awaiting requested review from weshayutin

Assignees

@mateusoliveira43 mateusoliveira43

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpryc @mateusoliveira43 @openshift-merge-robot