Make sure we are downloading newest version of the dependent tools #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpryc
force-pushed
the
operator_sdk_version
branch
from
87bba19 to
cfe22e5
Compare
mateusoliveira43
previously approved these changes
Apr 25, 2023
openshift-ci
bot
added
the
approved
Our current script does not always works as expected. In situation where latest tag of the dependent tool is pointing to the lower version then the newest one, the latest will be used. This modifies to incorporate semver checking of all the released versions and picking up the newest one (highest semver). Related issue: operator-framework/operator-sdk#6403 Related issue: dora-metrics#953 Signed-off-by: Michal Pryc <mpryc@redhat.com>
mpryc
force-pushed
the
operator_sdk_version
branch
from
cfe22e5 to
4124ebf
Compare
openshift-ci
bot
removed
the
approved
|
/test 4.10-e2e-openshift |
mateusoliveira43
approved these changes
Apr 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/test 4.11-e2e-openshift |
|
/test 4.9-e2e-openshift |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the behavior changes introduced in this PR
Our current script does not always works as expected.
In situation where latest tag of the dependent tool is pointing to the lower version then the newest one, the latest will be used.
This modifies to incorporate semver checking of all the released versions and picking up the newest one (highest semver).
Linked Issues
related to: operator-framework/operator-sdk#6403
related to: #953
Testing Instructions
Ran before and after modifications, the current links are exactly the same, because latest is pointing to the greatest semver so it's working as expected. We do not look at the latest tag at all, so the semver is calculating correctly the greatest version.