Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Create test images for PRs #948

Merged

Conversation

mateusoliveira43
Copy link
Collaborator

@mateusoliveira43 mateusoliveira43 commented Apr 19, 2023

Describe the behavior changes introduced in this PR

Create test images for each PR, making testing of operator easier for the developers.

Linked Issues

resolves #881
depends on #969

Testing Instructions

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr948-abc555 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mateusoliveira43. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

echo "pr_number=test" >> "$GITHUB_OUTPUT"
echo "commit_hash=test" >> "$GITHUB_OUTPUT"

# TODO delete-images:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I feel is important, but maybe we can address later

.github/workflows/test-images.yml Outdated Show resolved Hide resolved
.github/workflows/test-images.yml Show resolved Hide resolved
.github/workflows/trigger-test-images.yml Show resolved Hide resolved
.github/workflows/trigger-test-images.yml Show resolved Hide resolved
.github/workflows/trigger-test-images.yml Show resolved Hide resolved
scripts/chart-test.sh Outdated Show resolved Hide resolved
@openshift-ci
Copy link

openshift-ci bot commented Apr 21, 2023

@mpryc: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 4.10-e2e-openshift
  • /test 4.10-unit
  • /test 4.11-e2e-openshift
  • /test 4.11-unit
  • /test 4.8-e2e-openshift
  • /test 4.8-unit
  • /test 4.9-e2e-openshift
  • /test 4.9-unit

Use /test all to run all jobs.

In response to this:

Can the workflow make a comment? I am thinking here of a prow job that runs on a specific comment, e.g.

/test pelorus-operator-4.10-pre-check

?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpryc mpryc assigned mateusoliveira43 and unassigned mpryc Apr 21, 2023
@mateusoliveira43 mateusoliveira43 force-pushed the feat/test-images branch 2 times, most recently from bcc882a to 98f6bfe Compare April 26, 2023 20:01
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2023
@dpulls
Copy link

dpulls bot commented May 8, 2023

🎉 All dependencies have been resolved !

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2023
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mateusoliveira43 mateusoliveira43 marked this pull request as ready for review May 8, 2023 18:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2023
@openshift-ci openshift-ci bot requested review from KevinMGranger and mpryc May 8, 2023 18:14
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mateusoliveira43 mateusoliveira43 merged commit ee09c37 into dora-metrics:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build and deploy of Pelorus operator test images in quay
3 participants