-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for broken RBAC in the pelorus-operator 0.0.3 #851
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Testing if the bundle fixes the issue, but need a fresh cluster so will take 2-3h. |
pelorus-operator/helm-charts/pelorus/subcharts/exporters/templates/_imagestream.yaml
Outdated
Show resolved
Hide resolved
charts/pelorus/subcharts/exporters/templates/_imagestream_from_image.yaml
Show resolved
Hide resolved
This fixes RBAC issues with the pelorus-operator 0.0.3. There was another issue with the image tags within the image stream created for each individual exporter, which should be fixed by this PR. No need to create new Release as the pelorus-operator and pelrus-bundle may be created without new github release. Signed-off-by: Michal Pryc <mpryc@redhat.com>
/unhold Tested works as expected with different tags and deployment methods of the exporters. |
Note this will not pass the Chart lint as it's fix for already existing tag. |
Corresponding PR: redhat-openshift-ecosystem/community-operators-prod#2309 |
Merging. Our operator 0.0.4 is in marketplace and contains 1-1 copy of those files, confirmed it's fixing our issue #849 |
This fixes RBAC issues with the pelorus-operator 0.0.3.
There was another issue with the image tags within the image stream created for each individual exporter, which should be fixed by this PR.
No need to create new Release as the pelorus-operator and pelrus-bundle may be created without new github release.
Testing Instructions
operator-sdk run bundle quay.io/pelorus/pelorus-operator-bundle:v0.0.4
@redhat-cop/mdt