Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken RBAC in the pelorus-operator 0.0.3 #851

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

mpryc
Copy link
Collaborator

@mpryc mpryc commented Mar 2, 2023

This fixes RBAC issues with the pelorus-operator 0.0.3.

There was another issue with the image tags within the image stream created for each individual exporter, which should be fixed by this PR.

No need to create new Release as the pelorus-operator and pelrus-bundle may be created without new github release.

Testing Instructions

  1. Create new pelorus namespace
  2. make sure you activated venv of pelorus project (master should do)
  3. Run operator-sdk run bundle quay.io/pelorus/pelorus-operator-bundle:v0.0.4
  4. Create instance of the pelorus operator

@redhat-cop/mdt

@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mpryc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpryc
Copy link
Collaborator Author

mpryc commented Mar 2, 2023

/hold

Testing if the bundle fixes the issue, but need a fresh cluster so will take 2-3h.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2023
This fixes RBAC issues with the pelorus-operator 0.0.3.

There was another issue with the image tags within the image stream
created for each individual exporter, which should be fixed by this
PR.

No need to create new Release as the pelorus-operator and pelrus-bundle
may be created without new github release.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@mpryc
Copy link
Collaborator Author

mpryc commented Mar 2, 2023

/unhold

Tested works as expected with different tags and deployment methods of the exporters.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2023
@mpryc
Copy link
Collaborator Author

mpryc commented Mar 2, 2023

Note this will not pass the Chart lint as it's fix for already existing tag.

@mpryc
Copy link
Collaborator Author

mpryc commented Mar 2, 2023

@mpryc
Copy link
Collaborator Author

mpryc commented Mar 3, 2023

Merging. Our operator 0.0.4 is in marketplace and contains 1-1 copy of those files, confirmed it's fixing our issue #849

Screenshot from 2023-03-03 13-28-35

@mpryc mpryc merged commit cf05055 into dora-metrics:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants